Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish-lsp: init at 1.0.8-1 #330996

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fish-lsp: init at 1.0.8-1 #330996

wants to merge 2 commits into from
+82 −0

Conversation

petertriho
Copy link
Contributor

@petertriho petertriho commented Jul 30, 2024 •
edited
Loading

Description of changes

Adds fish-lsp #305493

Uses yarnConfigHook and yarnBuildHook instead of mkYarnPackage

Supersedes #320463 #330320

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@petertriho petertriho marked this pull request as ready for review July 30, 2024 04:33
@petertriho
Copy link
Contributor Author

petertriho commented Jul 30, 2024 •
edited
Loading

Note sure why both ofborg passthru.tests are stuck. Would appreciate help with this

@petertriho petertriho mentioned this pull request Jul 30, 2024
Closed
@petertriho
Copy link
Contributor Author

Result of nixpkgs-review pr 330996 run on x86_64-linux 1

2 packages built:
  • fish-lsp
  • nixpkgs-manual

@petertriho
Copy link
Contributor Author

Looks like all tests have passed. Is there anything else I should do to get this merged?

@gungun974 gungun974 mentioned this pull request Aug 9, 2024
Closed
13 tasks
@tye-exe
Copy link

tye-exe commented Aug 24, 2024

Thanks for putting in the work to do this, i've just spent the last few hours trying to do it myself before i found this. Does anyone know the timeline until this will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petertriho @tye-exe